Skip to content

Fixed MLXArray storage order #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

stemann
Copy link
Owner

@stemann stemann commented May 4, 2025

Also:

  • Added necessary eval of MLX array data in Base.unsafe_convert(::Type{Ptr{T}}, array::MLXArray{T, N})

Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.46%. Comparing base (6a993e1) to head (b66fd85).

Files with missing lines Patch % Lines
src/device.jl 85.71% 1 Missing ⚠️
src/utils.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   22.73%   24.46%   +1.72%     
==========================================
  Files           7        8       +1     
  Lines        1179     1206      +27     
==========================================
+ Hits          268      295      +27     
  Misses        911      911              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stemann stemann force-pushed the feature/storage_order branch from 08be121 to b66fd85 Compare May 4, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant