Skip to content

Implemented broadcasting for MLXArray #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stemann
Copy link
Owner

@stemann stemann commented Mar 26, 2025

No description provided.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 24.45%. Comparing base (6a993e1) to head (776b8d6).

Files with missing lines Patch % Lines
src/array.jl 87.50% 2 Missing ⚠️
src/device.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   22.73%   24.45%   +1.72%     
==========================================
  Files           7        7              
  Lines        1179     1202      +23     
==========================================
+ Hits          268      294      +26     
+ Misses        911      908       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stemann stemann force-pushed the feature/broadcasting branch 3 times, most recently from 9fcd4c1 to afc4ebd Compare March 26, 2025 09:37
@stemann stemann force-pushed the feature/broadcasting branch 2 times, most recently from 7b180b7 to f20bbeb Compare April 6, 2025 07:40
Also:
* Added necessary eval of MLX array data in Base.unsafe_convert(::Type{Ptr{T}}, array::MLXArray{T, N})
* Implemented Base.similar for MLXArray.
* Added supported_number_types(::DeviceType = DeviceTypeCPU)
@stemann stemann force-pushed the feature/broadcasting branch from f20bbeb to 776b8d6 Compare April 6, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant