final TSS changes #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya1702
approved these changes
Nov 12, 2024
| @@ -33,7 +33,7 @@ func ErrorHandlerJitterChannelBufferSizeOption(configKey *int) *config.ConfigOpt | |||
| Usage: "Set the buffer size of the Error Handler Jitter channel.", | |||
| OptType: types.Int, | |||
| ConfigKey: configKey, | |||
| FlagDefault: 100, | |||
| FlagDefault: 1000, | |||
There was a problem hiding this comment.
Is there a way in which we determined these values? Or are they just a random default value right now?
There was a problem hiding this comment.
It's not completely random. It's based on the number of the expected TSS transaction submission requests at peak load. So peak QPS in a sense. This buffer size is the maximum number of tasks that this go routine pool can handle at any given time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
final TSS changes made after TSS testing
Why
final TSS changes made after TSS testing
Known limitations
N/A
Issue that this PR addresses
[TODO: Attach the link to the GitHub issue or task. Include the priority of the task here in addition to the link.]
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release