Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

Commit

Permalink
remove Sub, add some notes
Browse files Browse the repository at this point in the history
  • Loading branch information
cathieyun committed Feb 27, 2019
1 parent 5c9585b commit 8a7aab1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
1 change: 1 addition & 0 deletions zkvm/docs/zkvm-spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -1368,6 +1368,7 @@ _constr_ **verify** → ø
2. Transforms the constraint `constr` recursively using the following rules:
1. Replace conjunction of two _linear constraints_ `a` and `b` with a linear constraint `c` by combining both constraints with a random challenge `z`:
```
z = transcript.challenge_scalar(b"ZkVM.verify.and-challenge");
c = a + z·b
```
2. Replace disjunction of two _linear constraints_ `a` and `b` by constrainting an output `o` of a newly allocated multiplier `{r,l,o}` to zero, while adding constraints `r == a` and `l == b` to the constraint system.
Expand Down
8 changes: 0 additions & 8 deletions zkvm/src/constraints.rs
Original file line number Diff line number Diff line change
Expand Up @@ -257,14 +257,6 @@ impl Add for Expression {
}
}

impl Sub for Expression {
type Output = Expression;

fn sub(self, rhs: Expression) -> Expression {
self + -rhs
}
}

// Upcasting witness/points into Commitment

impl From<CommitmentWitness> for Commitment {
Expand Down

0 comments on commit 8a7aab1

Please sign in to comment.