feat(serde): add serde_with support for serialization #72
+54
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optionally provide serialization with serde_with. Since the types already provide `Display` and `FromStr` we can use `serde_with` to provide `serde` support. This will allow storing strkeys in config files with their types and not just `String`.
willemneal
force-pushed
the
feat/serde_with
branch
from
3442e86
to
64952ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Optionally provide serialization with serde_with. Since the types already provide
DisplayandFromStrwe can useserde_withto provideserdesupport.Why
This will allow storing strkeys in config files with their types and not just
String.Known limitations
[TODO or N/A]