Add Lab to quickstart #678
Conversation
|
What's the impact on image size and container memory and cpu usage? |
| @@ -26,6 +27,7 @@ export PGPORT=5432 | |||
| : "${ENABLE_LOGS:=false}" | |||
| : "${ENABLE_CORE:=false}" | |||
| : "${ENABLE_HORIZON:=false}" | |||
| : "${ENABLE_LAB:=false}" | |||
There was a problem hiding this comment.
Can we remove the enable lab env and instead rely on the enable env var? The other ones for core and horizon are legacy.
There was a problem hiding this comment.
Sorry, the env can stay, but can we hook it into the ENABLE car as well?
| COPY --from=stellar-rpc /bin/stellar-rpc /usr/bin/stellar-rpc | ||
| COPY --from=lab /lab /opt/stellar/lab | ||
| COPY --from=lab /usr/local/bin/node \ |
There was a problem hiding this comment.
I thought the lab is a static website. Can we build the static site and host it with nginx instead?
There was a problem hiding this comment.
I don't think it is, but I asked in Slack anyway.
@leighmcculloch Unfortunately, is node.js tire fire all around. $ du -hs /stellar/lab/node_modules/
786M /stellar/lab/node_modules/
$ du -hs /stellar/lab/build/
314M /stellar/lab/build/As for memory and cpu, it should be fine. $ ps auxwww | grep next
stellar 619 0.1 0.3 22331024 125484 pts/0 Sl 01:52 0:01 next-server (v14.2.26) |
|
Oof. I think we should make changes to Lab if needed to make it generatable as a static website. An additional 1GB of image size is multiple times the current size of the image. |
No description provided.