-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network selector: setup for custom headers #1101
Conversation
Preview is available here: |
Preview is available here: |
Waiting on a fix in JS Stellar SDK |
Preview is available here: |
Preview is available here: |
) => { | ||
if (method === "rpc" && network.rpcHeaderName) { | ||
return { [network.rpcHeaderName]: network.rpcHeaderValue || "" }; | ||
} else if (method === "horizon" && network.horizonHeaderName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is else if
better than just using if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to future-proof these cases. If we add another method in the future, the else
case would also include that, but we probably won't want it.
Preview is available here: |
Server
s is misbehaving js-stellar-sdk#1088 is ready