-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the Soroban RPC client into this library #860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Size Change: +847 kB (+8%) 🔍 Total Size: 12.1 MB
|
a36a22d
to
21bd09f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, getting this all wrangled together, I didn't review most of the copied soroban-client code, just focused on the exports, module layouts, and left a couple comments for consideration.
What
This merges the
soroban-client
library (stellar/js-soroban-client) into this package.The namespaces have changed to move each server-dependent component into its own module. There is a detailed migration guide written here which should outline both the literal (i.e. necessary code changes) and philosophical (i.e. how to find certain functionality) changes needed to adapt to this merge.
The code changes themselves are:
Why
It is incredibly likely that most applications will need to interface with both Horizon and Soroban if they plan on supporting the entire feature set that Stellar has to offer. Putting things into a single library means less duplicated dependencies and a better, all-inclusive experience. Additionally, the amount of shared code and build dependencies across these two libraries means it makes sense to combine them into one.
Closes #850.
Known Limitations
TODOs Remaining