Add PKCS8 Key Import Support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Aug 29, 2019
|
Probably worth adding a simple test as well. |
|
I added a test and moved up the free, though it looks like CI is failing for unrelated reasons. Any ideas as to what might be going on? |
|
@Goirad Please rebase against master, CI is fixed and all green again. |
|
@steffengy rebased, would love any feedback or suggestions |
|
lgtm |
jethrogb
reviewed
Sep 3, 2019
|
As we currently do not support importing ECC keys, I think if there're no further objections we're fine landing this as is for now. |
|
None from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial implementation for importing a key into
ImportOptions, and is required for this PR innative-tls.