Update to latest version of CUE #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
24a8801
to
42fb187
Compare
errordeveloper
commented
Sep 10, 2024
Comment on lines
+44
to
+69
| #AlertProviderSpec: matchN(1, [{ | ||
| type!: _ | ||
| address!: _ | ||
| }, { | ||
| type!: _ | ||
| secretRef!: _ | ||
| }]) & { | ||
| // Hook URL address of this provider | ||
| address?: string | ||
|
|
||
| // Alert channel for this provider | ||
| channel?: string | ||
|
|
||
| // Http/s proxy of this provider | ||
| proxy?: string | ||
| secretRef?: { | ||
| // Name of the Kubernetes secret | ||
| name!: string | ||
| } | ||
|
|
||
| // Type of this provider | ||
| type?: "slack" | "msteams" | "discord" | "rocket" | "gchat" | ||
|
|
||
| // Bot username for this provider | ||
| username?: string | ||
| } |
There was a problem hiding this comment.
@stefanprodan I suppose this one might be small enough to eyeball? 😅
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
42fb187
to
0532660
Compare
curl --location --silent \ https://raw.githubusercontent.com/fluxcd/flagger/v1.38.0/artifacts/flagger/crd.yaml \ --output flagger.crds.yaml
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
0532660
to
dd63ac3
Compare
|
Adding a bump for gomega, as it gets only a shy +1 as part of CUE bump, might as well get the very latest. |
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
10b8da8
to
64bc1d2
Compare
There was a problem hiding this comment.
Thanks @errordeveloper! Really happy to see the CRD import working for oneOf/anyOf 🎉
| @@ -3,7 +3,7 @@ module github.com/stefanprodan/timoni | |||
| go 1.22.0 | |||
|
|
|||
| require ( | |||
| cuelang.org/go v0.9.2 | |||
| cuelang.org/go v0.11.0-alpha.1.0.20240910060539-63413629e06b | |||
There was a problem hiding this comment.
We'll need to wait for v0.11.0 to go GA before merging.
There was a problem hiding this comment.
Yes... only if one could use build tags in 'go.mod'!
|
Should we add test cases for all verbs? I think Flagger CRD has only one of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUE now has resolved the CRD import issue with
oneOf,not, andanyOf(#336) as well required fields. This PR integrates latest revision and updates tests.