Skip to content

Commit

Permalink
Merge pull request #320 from duxinxiao/patch-1
Browse files Browse the repository at this point in the history
Add comment on sleep during graceful shutdown
  • Loading branch information
stefanprodan committed Nov 15, 2023
2 parents d9bc630 + 074d0f9 commit 73fcdbe
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/signals/shutdown.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ func (s *Shutdown) Graceful(stopCh <-chan struct{}, httpServer *http.Server, htt

s.logger.Info("Shutting down HTTP/HTTPS server", zap.Duration("timeout", s.serverShutdownTimeout))

// wait for Kubernetes readiness probe to remove this instance from the load balancer
// There could be a period where a terminating pod may still receive requests. Implementing a brief wait can mitigate this.
// See: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination
// the readiness check interval must be lower than the timeout
if viper.GetString("level") != "debug" {
time.Sleep(3 * time.Second)
Expand Down

0 comments on commit 73fcdbe

Please sign in to comment.