Align with HTML5 Boilerplate #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
added a commit
that referenced
this pull request
Nov 29, 2013
Align with HTML5 Boilerplate
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal alignment to avoid any clashes. In summary:
I did not bother with any JS related items (Modernizr and jQuery), as EAK developers will likely have a specific set of JS project requirements to suit their own tastes. I also did not copy the Google Analytics snippet as GA requires a little extra attention when dealing with Ember, and not sure if EAK wants to be opinionated on visitor tracking services anyway.
I did not copy over favicon or the Apple touch icon as these are H5BP branded. I figure once the matter of EAK's logo is sorted out, we can add these final boilerplate items.
Resolves #339