Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem when nan values occur in inflow driven calculations #5

Closed
wants to merge 1 commit into from

Conversation

cardosan
Copy link
Contributor

All nan in inflow driven calculations are changed to zeros for both inflow and outflow by cohort computations . Fixes #4

P.S: maybe the same prob with nan occurs also in stock driven calculations. Do not know since I am not using it

All nan in inflow driven calculations are changed to zeros for both inflow and outflow by cohort computations . Fixes stefanpauliuk#4

P.S: maybe the same prob with nan occurs also in stock driven calculations. Do not know since I am not using it
@stefanpauliuk
Copy link
Owner

If nan occurs as a result of a calculation, it should not be set to 0 automatically. Rather, the user needs to make sure after every calculation step whether the result is as indended and correct the data if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants