Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded paths from URI #24

Merged

Conversation

samueljackson92
Copy link
Contributor

@samueljackson92 samueljackson92 commented Aug 7, 2023

Hi,

I wanted to play with wands locally, but I am hindered by hardcoded paths in the server. Here's a quick PR to fix it.

@stefaniereuter
Copy link
Owner

@jholloc I think this would be a quick fix to one part of issue #13 . The other idea would be to have a config file on the server side. What do you think makes more sense. I see pros and cons in both options: if you send over the whole path from the client side you need to know exactly where the data is located on the server side I'm not sure if this is the case. But if you avoid having a server config file you can basically run the server and don't have to specify anything on the server side and can send everything over from the client side. What do you think?

@samueljackson92
Copy link
Contributor Author

@stefaniereuter One idea might be to support both? If you provide an absolute path /path/to/file.h5 then it works as expected, but the proposed configuration file could support a working_dir or similar property allowing you to use paths like ./relative/path/to/file.h5?

@stefaniereuter
Copy link
Owner

@samueljackson92 I like that. I'll merge the pull request and then add a comment to the issue #13 that this then needs updating in the documentation and the check if an absolute path was sent.

Copy link
Owner

@stefaniereuter stefaniereuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge. As discussed in pull request issue #13 will be modified to support absolute paths and just files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants