Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO-NOT-MERGE: tpm2: Replace deprecated symmetric functions with EVP functions (OSSL 3) #349

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

DO-NOT-MERGE: tpm2: Replace deprecated symmetric functions with EVP functions (OSSL 3) #349

wants to merge 2 commits into from

Conversation

stefanberger
Copy link
Owner

This PR replaces most usage of old OpenSSL symmetric function with calls to EVP functions.

@stefanberger stefanberger marked this pull request as draft February 10, 2023 17:50
@coveralls
Copy link

coveralls commented Feb 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 2712

  • 56 of 64 (87.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 76.334%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tpm2/crypto/openssl/TpmToOsslDesSupport.c 7 8 87.5%
src/tpm2/crypto/openssl/Helpers.c 16 18 88.89%
src/tpm2/crypto/openssl/CryptCmac.c 32 37 86.49%
Totals Coverage Status
Change from base Build 2710: 0.02%
Covered Lines: 33739
Relevant Lines: 44199
💛 - Coveralls

@stefanberger
Copy link
Owner Author

stefanberger commented Feb 10, 2023 •
edited
Loading

A definite downside for using the EVP APIs is that they are computationally much more involved. This alone should be a reason not to change to the EVP APIs but rather us the low-level functions (until they get removed at least).

@stefanberger stefanberger changed the title Replace deprecated symmetric functins with EVP functions Replace deprecated symmetric functions with EVP functions Feb 11, 2023
@stefanberger stefanberger force-pushed the stefanberger/ossl3_symmetric_functions branch 2 times, most recently from ea71c4d to b5141b9 Compare February 13, 2023 12:46
@stefanberger stefanberger changed the title Replace deprecated symmetric functions with EVP functions Replace deprecated symmetric functions with EVP functions (OSSL 3) Feb 13, 2023
@stefanberger stefanberger changed the title Replace deprecated symmetric functions with EVP functions (OSSL 3) tpm: Replace deprecated symmetric functions with EVP functions (OSSL 3) Feb 15, 2023
@stefanberger stefanberger changed the title tpm: Replace deprecated symmetric functions with EVP functions (OSSL 3) tpm2: Replace deprecated symmetric functions with EVP functions (OSSL 3) Feb 15, 2023
@stefanberger stefanberger force-pushed the stefanberger/ossl3_symmetric_functions branch 4 times, most recently from 3822b59 to c0fa453 Compare February 28, 2023 17:14
@stefanberger stefanberger force-pushed the stefanberger/ossl3_symmetric_functions branch from c0fa453 to 233e81b Compare February 28, 2023 18:52
stefanberger
stefanberger commented Feb 28, 2023
View reviewed changes
src/tpm2/crypto/openssl/TpmToOsslDesSupport.c
@@ -101,6 +102,7 @@ void TDES_encrypt(
&ks[0], &ks[1], &ks[2],
DES_ENCRYPT);
}

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray newline

@stefanberger stefanberger changed the title tpm2: Replace deprecated symmetric functions with EVP functions (OSSL 3) DO-NOT-MERGE: tpm2: Replace deprecated symmetric functions with EVP functions (OSSL 3) Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanberger @coveralls