-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added favicon size to google provider #13
Open
jayenne
wants to merge
6
commits into
stefanbauer:master
Choose a base branch
from
jayenne:add_favicon_size_to_google_provider
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c4479b
Added favicon size to google provider
jayenne 0e95e00
Add storage disk to `fetchAndSaveTo`
jayenne 3a9c721
set default disk
jayenne 089220b
Changed provider variables to camelCase
jayenne fcda5f5
Added new providers for Allesev, Unavatar and Yandex
jayenne f4a7db6
Merge branch 'stefanbauer:master' into add_favicon_size_to_google_pro…
jayenne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace StefanBauer\LaravelFaviconExtractor\Provider; | ||
|
||
use GrahamCampbell\GuzzleFactory\GuzzleFactory; | ||
|
||
class GoogleProvider implements ProviderInterface | ||
{ | ||
public function fetchFromUrl(string $url): string | ||
{ | ||
$client = GuzzleFactory::make(); | ||
$response = $client->get($this->getUrl($url)); | ||
|
||
return $response->getBody()->getContents(); | ||
} | ||
|
||
private function getUrl(string $url): string | ||
{ | ||
$faviconSize = config('favicon-extractor.favicon_size', 32); | ||
$sizeQuery = $faviconSize.'/'; | ||
return 'https://f1.allesedv.com/'.$sizeQuery.urlencode($url); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,8 @@ public function fetchFromUrl(string $url): string | |
|
||
private function getUrl(string $url): string | ||
{ | ||
return 'https://www.google.com/s2/favicons?domain='.urlencode($url); | ||
$faviconSize = config('favicon-extractor.favicon_size', 32); | ||
$sizeQuery = '&sz='.$faviconSize; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing line-break before |
||
return 'https://www.google.com/s2/favicons?domain='.urlencode($url).$sizeQuery; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace StefanBauer\LaravelFaviconExtractor\Provider; | ||
|
||
use GrahamCampbell\GuzzleFactory\GuzzleFactory; | ||
|
||
class GoogleProvider implements ProviderInterface | ||
{ | ||
public function fetchFromUrl(string $url): string | ||
{ | ||
$client = GuzzleFactory::make(); | ||
$response = $client->get($this->getUrl($url)); | ||
|
||
return $response->getBody()->getContents(); | ||
} | ||
|
||
private function getUrl(string $url): string | ||
{ | ||
// accpts a domain, username or email, | ||
return 'https://unavatar.io/'.urlencode($url); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace StefanBauer\LaravelFaviconExtractor\Provider; | ||
|
||
use GrahamCampbell\GuzzleFactory\GuzzleFactory; | ||
|
||
class GoogleProvider implements ProviderInterface | ||
{ | ||
public function fetchFromUrl(string $url): string | ||
{ | ||
$client = GuzzleFactory::make(); | ||
$response = $client->get($this->getUrl($url)); | ||
|
||
return $response->getBody()->getContents(); | ||
} | ||
|
||
private function getUrl(string $url): string | ||
{ | ||
// size options are limited to 16 & 32 | ||
$faviconSize = config('favicon-extractor.favicon_size', 32) > 16 ? 32 : 16; | ||
$sizeQuery = '?size='.$faviconSize; | ||
return 'https://favicon.yandex.net/favicon/'.urlencode($url).$sizeQuery; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing line-break before |
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing line-break before
return