Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invocable initialization should not remove config values that are empty strings #593

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Invocable initialization should not remove config values that are empty strings #593

merged 2 commits into from
Nov 10, 2023

Conversation

dkolas
Copy link
Contributor

@dkolas dkolas commented Nov 7, 2023

No description provided.

@douglas-reid douglas-reid changed the title Invocable initialization should not remove config values that are emtpy strings Invocable initialization should not remove config values that are empty strings Nov 10, 2023
@dkolas dkolas added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 0c19da1 Nov 10, 2023
4 checks passed
@jcechavarri jcechavarri mentioned this pull request Jan 19, 2024
Closed
GitOnUp added a commit that referenced this pull request Jan 24, 2024
@GitOnUp
Revert "Invocable initialization should not remove config values that…
d46f1c1 
… are empty strings (#593)"

This reverts commit 0c19da1.
@GitOnUp GitOnUp mentioned this pull request Jan 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2024
@GitOnUp
Roll back secrets change (#600)
1120c4c 
Reverts "Invocable initialization should not remove config values that
are empty strings (#593)"

This reverts commit 0c19da1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglas-reid douglas-reid douglas-reid approved these changes

@eob eob Awaiting requested review from eob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkolas @douglas-reid