New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASIO backend #6

Open

AndySaul wants to merge 100 commits into stdcpp-audio:master from AndySaul:asio_backend

AndySaul commented May 27, 2019 •

edited

Loading

This adds a Windows ASIO backend to the library.

Currently, the ASIO driver is the default option as there is no WASAPI implementation. The device selection API would need to be templatized as per 6.4 to allow this.

gsomberg314 reviewed

View reviewed changes

examples/sine_wave.cpp Outdated Show resolved Hide resolved

gsomberg314 reviewed

View reviewed changes

include/__audio_buffer.h Outdated Show resolved Hide resolved

gsomberg314 reviewed

View reviewed changes

include/cpp/span.hpp Outdated Show resolved Hide resolved

gsomberg314 reviewed

View reviewed changes

include/audio_backend/__asio_audio_device.h Outdated Show resolved Hide resolved

gsomberg314 reviewed

View reviewed changes

include/audio_backend/__asio_audio_device.h Outdated Show resolved Hide resolved

gsomberg314 reviewed

View reviewed changes

include/audio_backend/__asio_audio_device.h Outdated Show resolved Hide resolved

gsomberg314 reviewed

View reviewed changes

Contributor

gsomberg314 left a comment

Thanks for implementing this! I've made a few comments, and then we can merge this in.

Author

AndySaul commented Jun 2, 2019

Hi Guy,

Thanks for the review :)

I will make changes & comment as requested

Author

AndySaul commented Jun 2, 2019

I need to rebase on top of master so that this can be merged. I may take the opportunity to squash in some of the latest changes

andy-sandbox added 21 commits

June 2, 2019 15:36


          Set Visual Studio flags in CMake

5cda687


          Modify __null_backend to compile on Windows

88aa731


          Modify __audio_buffer to compile on Windows

4b86b3e


          Specify _USE_MATH_DEFINES on Windows

add97fd


          Add <atomic> header that was previously only included transitively

dc8dfbd


          Cast M_PI to float to avoid narrowing conversion warning

7f47153


          Removed unused parameter

ad43986

All samples now compile without error on Windows


          Use const where possible

be138d2


          Add __windows_backend.h

7202ebb

This is a copy of __null_backend.h initially


          Use forward_list for Windows audio_driver_list

e7ab4c2


          Move ASIO audio_device class into its own file

7347d35


          Delegate device selection API calls to __asio_devices

2a860b7


          Read ASIO driver info from registry

bfd8ff6


          Ignore win_build directory

0ef1a24


          Enumerate ASIO devices

7f72d5a


          Implement sample rate accessors

3c1602d


          Implement buffer size accessors

8962a9c


          Add audio_device_exception & _running member

7f78517


          Retrieve the ASIO driver's sample type

9b4adbb

ASIO drivers use different underlying sample types so that the driver
can specify an efficient native format. P1386R1 has no mechanism to
query native sample type.


          Set the callback for the default (float) sample type

966905a


          Implement the ASIO callbacks

5e19c0e

AndySaul changed the title ~~Asio backend~~ ASIO backend

AndySaul and others added 28 commits

June 11, 2019 19:28


          Do not throw if ASIO reg key is not read

50f87b7

This is to be expected on hosts without ASIO drivers.
If the root ASIO key is not found, enumerating subkeys will fail, so
ASIO devices will not be created


          Use method name to convey intent

f7d65cf


          Tidy up __asio_device::enumerate

fdb0ab1


          Add .clang-format file to keep style consistent

931de46


          Use template<class> consistently

2e4ed65

As per Specification Style Guidelines


          Use braced initialisation for members consistently

ceaf996


          Rename type

2c95cc6


          Apply clang-tidy fixes

c337979


          Apply clang-tidy fixes

9f59a9c


          Merge remote-tracking branch 'upstream/master'

bcd100d


          Use size_t for loop iteration

0e38341


          Merge branch 'master' into asio_backend

c9426c1


          Don't expose Windows max macro to audio clients

253cc44


          Add null implementation of set_audio_device_list_callback

3c38016


          Use size_t for loop iteration

c08eeb3


          Remove empty statement


          Remove functions that have been removed from API

24cf0e1


          Remove span, it is no longer used in the project

59b2d15


          Remove unnecessary temporary

2ed7e68


          Suppress clang-format warnings

1fa4a45


          Delete methods removed from specification

6d044cf


          Fix clang-tidy warnings

82fe582


          Reformat


          Push __asio_sample class into common header

c842ce1


          Push main functions into common header

d0d171b


          Consolidate all ASIO code in __asio_backend.h

42d94df


          Consolidate all ASIO code into __asio_backend.h

54d9b1e


          Fix hicpp-signed-bitwise warning rather than suppressing it

6b56435

falkTX commented Jan 21, 2022

How is this going to work with the ASIO SDK being proprietary?
Did you have permission from Steinberg for adding the SDK files here? If not, will compilers have to agree with ASIO/Steinberg's terms in order to build such backend?

On GCC where GPL is used as license, the ASIO SDK is inherently incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet