Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0 #523

Merged
merged 139 commits into from
Sep 25, 2024
Merged

2.0 #523

merged 139 commits into from
Sep 25, 2024

Conversation

prichodko
Copy link
Collaborator

@prichodko prichodko commented Jan 22, 2024 •
edited
Loading

Why

Reducing complexity improves maintainability, and thus, simplicity should be a key goal of the systems we build.

Static CSS is the most future-proof solution.

Setup

  • setup tailwind
  • Storybook
  • Remove Tamagui
  • Remove apps and examples
  • create a shared tailwind config
  • support dark/light, customisation, blur/shell variants

Components

  • Avatar
  • Button
  • Checkbox
  • ContextTag
  • Counter
  • DropdownButton
  • DropdownMenu
  • IconButton
  • Input
  • Popover
  • StatusProvider
  • Shortcut
  • Skeleton
  • Step
  • Tabs
  • Tag
  • Text
  • Toast
  • ToastContainer
  • Tooltip

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7e1dd83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@status-im/eslint-config Major
@status-im/components Major
@status-im/js Major
@status-im/colors Major
@status-im/icons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 22, 2024

@prichodko is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-components ✅ Ready (Inspect) Visit Preview 💬 2 unresolved
✅ 1 resolved		 Sep 25, 2024 2:54pm

@prichodko prichodko changed the base branch from main to multi-entry-icons September 10, 2024 16:22
@prichodko prichodko marked this pull request as ready for review September 21, 2024 14:29
felicio
felicio approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@felicio felicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, and could you please

@felicio
Copy link
Collaborator

felicio commented Sep 23, 2024

Approved, and could you please

Also, seems like a good opportunity to update readme and licenses.

@felicio
Copy link
Collaborator

felicio commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 7b6e2ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

this

@felicio
Copy link
Collaborator

felicio commented Sep 23, 2024

https://vercel.com/status-im-web/status-web can be deleted

This was referenced Sep 23, 2024
Closed
Merged
@prichodko prichodko changed the title Switch to tailwind 2.0 Sep 24, 2024
@prichodko prichodko changed the base branch from multi-entry-icons to main September 24, 2024 17:54
@prichodko
Copy link
Collaborator Author

prichodko commented Sep 24, 2024 •
edited
Loading

remove vars the from vercel if not done already

✅

https://vercel.com/status-im-web/status-web can be deleted

disconnected ✅

@prichodko
Copy link
Collaborator Author

prichodko commented Sep 24, 2024 •
edited
Loading

seems like a good opportunity to update readme

updated

@prichodko prichodko force-pushed the tailwind branch 3 times, most recently from b08cf40 to 503fca5 Compare September 24, 2024 18:32
jkbktl
jkbktl approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@jkbktl jkbktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM
Left just couple of comments on Vercel to think about it.

prichodko
prichodko commented Sep 25, 2024
View reviewed changes
packages/components/tailwind.config.ts
@@ -174,111 +119,121 @@ export default {
plugin(({ addUtilities, addBase }) => {
addBase({
'[data-customisation="army"]': {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS variables don't support /

@prichodko prichodko self-assigned this Sep 25, 2024
@prichodko prichodko merged commit edfdfd6 into status-im:main Sep 25, 2024
1 of 2 checks passed
@prichodko prichodko deleted the tailwind branch September 25, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbktl jkbktl jkbktl approved these changes

@felicio felicio felicio approved these changes

Assignees

@prichodko prichodko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prichodko @felicio @jkbktl