Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update legal-docs submodule and resources with updated terms-o… #21832

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

seanstrom
Copy link
Member

Attention

cc @alwx


fixes: #21783

Summary

  • This PR attempts to update the legal-docs submodule to the latest version.
  • And this PR attempts to update the terms-of-use resource with the latest revisions based on the legal-docs submodule.
    • Currently, the resource document is being updated to include revisions from September 19th 2024 and December 10th 2024, so the diff may appear larger than expected.
    • At the moment, we have slightly different formats for the terms-of-use resource used inside the app, and the terms-of-use document provided by the legal-docs submodule.
      • For example, it seems we do not render the # header syntax inside the app, so we need to create a function to format the official document for the app.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Terms of Use

Steps to test

WIP

Before and after screenshots comparison

WIP

status: ready

@seanstrom seanstrom requested a review from alwx December 16, 2024 20:12
@seanstrom seanstrom self-assigned this Dec 16, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 16, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 768088f #1 2024-12-16 20:18:14 ~5 min tests 📄log
✔️ 768088f #1 2024-12-16 20:19:56 ~7 min ios 📱ipa 📲
✔️ 768088f #1 2024-12-16 20:22:16 ~9 min android-e2e 🤖apk 📲
✔️ 768088f #1 2024-12-16 20:22:47 ~10 min android 🤖apk 📲
✔️ 240a6c7 #2 2025-01-10 11:16:23 ~5 min tests 📄log
✔️ 240a6c7 #2 2025-01-10 11:21:09 ~9 min android-e2e 🤖apk 📲
✔️ 240a6c7 #2 2025-01-10 11:21:48 ~10 min android 🤖apk 📲
✔️ 240a6c7 #2 2025-01-10 11:26:23 ~15 min ios 📱ipa 📲

@alwx alwx merged commit 1b30b3b into develop Jan 10, 2025
5 checks passed
@alwx alwx deleted the seanstrom/update-legal-docs-submodule-and-resources branch January 10, 2025 11:27
@alwx
Copy link
Contributor

alwx commented Jan 10, 2025

Merged because it's a duplicate of the PR that was merged before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

Update Terms of Use
3 participants