fix_: handle network change for filter subs #6232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (96)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6232 +/- ##
===========================================
+ Coverage 61.40% 61.44% +0.04%
===========================================
Files 834 834
Lines 109945 109945
===========================================
+ Hits 67513 67558 +45
+ Misses 34522 34494 -28
+ Partials 7910 7893 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chaitanyaprem
force-pushed
the
fix/filter-network-change
branch
7 times, most recently
from
9f7734d to
f35a82f
Compare
chaitanyaprem
force-pushed
the
fix/filter-network-change
branch
5 times, most recently
from
9a67352 to
c4b5777
Compare
osmaczko
approved these changes
Jan 7, 2025
kaichaosun
approved these changes
Jan 8, 2025
chaitanyaprem
force-pushed
the
fix/filter-network-change
branch
from
c4b5777 to
58707e7
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks changes from waku-org/go-waku#1270 to handle network change scenarios especially in mobile.
A description to understand introduced changes without reading the code.
Important changes:
Closes #