chore(config)_: integrate new rpc providers configs #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friofry
requested review from
saledjenic,
alaibe,
dlipicar and
Khushboo-dev-cpp
Jenkins BuildsClick to see older builds (56)
|
friofry
force-pushed
the
ab/issue-5997-rpc-providers-integration
branch
2 times, most recently
from
e0e484f to
d2795bc
Compare
|
todo:
|
|
todo:
|
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
2 times, most recently
from
1ecae6e to
afb9730
Compare
friofry
force-pushed
the
ab/issue-5997-rpc-providers-integration
branch
from
d2795bc to
526f19c
Compare
1 task
friofry
force-pushed
the
ab/issue-5997-rpc-providers-integration
branch
from
526f19c to
54f6a89
Compare
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
2 times, most recently
from
1c51d12 to
c1b756f
Compare
Base automatically changed from
ab/issue-5997-rpc-providers-configuration
to
develop
January 10, 2025 22:02
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6178 +/- ##
============================================
- Coverage 60.05% 19.13% -40.92%
============================================
Files 832 817 -15
Lines 109840 108221 -1619
============================================
- Hits 65961 20713 -45248
- Misses 36148 84685 +48537
+ Partials 7731 2823 -4908
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* default_networks.go * explicit provider initialization with more granular config (rps limiter, order) * token overrides made more flexible, support not only infura and grove * get_status_node.go * override status-proxy auth instead of passing override config to rpc/client.go * config.go * ProviderConfig removed * client.go * Now any provider can be enabled/disabled (if user wants to use only his custom RPC urls) * Use bearer auth instead of URL auth * Provider order is defined by default_networks.go
* add method to make a deepcopy of a network + tests * improved logging * improved memory allocation
friofry
force-pushed
the
ab/issue-5997-rpc-providers-integration
branch
from
54f6a89 to
8582775
Compare
igor-sirotin
approved these changes
Jan 13, 2025
|
|
||
| rpcProviders := []params.RpcProvider{ | ||
| // Proxy providers | ||
| *params.NewProxyProvider(chainID, "proxy-nodefleet", proxyUrl(stageName, "nodefleet", chainName, networkName), false), |
There was a problem hiding this comment.
Looks like all these strings ("proxy-nodefleet", "nodefleet", etc) should be defined as const variables.
| require.True(t, strings.Contains(n.FallbackURL, ganacheURL)) | ||
| // Check direct providers for tokens | ||
| for _, provider := range n.RpcProviders { | ||
| if provider.Type == params.EmbeddedDirectProviderType { |
There was a problem hiding this comment.
🙏
Suggested change
| if provider.Type == params.EmbeddedDirectProviderType { | |
| if provider.Type != params.EmbeddedDirectProviderType { | |
| continue |
| @@ -117,19 +118,25 @@ func OverrideEmbeddedProxyProviders(networks []params.Network, enabled bool, use | |||
| return updatedNetworks | |||
| } | |||
|
|
|||
| func deepCopyNetworks(networks []params.Network) []params.Network { | |||
| func DeepCopyNetwork(network params.Network) params.Network { | |||
There was a problem hiding this comment.
Perhaps this could be a method of params.network?
There was a problem hiding this comment.
I agree with Igor's suggestion for this and the function below.
Comment on lines
+300
to
+301
| if provider.AuthType != params.NoAuth { | ||
| switch provider.AuthType { |
There was a problem hiding this comment.
Why check if NoAuth, if the switch/case already does it? 🤔
| return fmt.Errorf("failed to begin transaction: %w", err) | ||
| } | ||
| defer func() { | ||
| if p := recover(); p != nil { |
There was a problem hiding this comment.
Oh, this is an smart thing to rollback in case of a panic 👍
Perhaps we should do this for all db transactions? Or at least write it down as a guideline?
| @@ -102,3 +102,14 @@ func CompareNetworksList(t require.TestingT, expectedNetworks, actualNetworks [] | |||
| CompareNetworks(t, expectedNetwork, network) | |||
| } | |||
| } | |||
|
|
|||
| func ConvertNetworksToPointers(networks []params.Network) []*params.Network { | |||
There was a problem hiding this comment.
Suggested change
| func ConvertNetworksToPointers(networks []params.Network) []*params.Network { | |
| func DereferenceNetworks(networks []params.Network) []*params.Network { |
There was a problem hiding this comment.
Though Dereference is the opposite thing 🤔 😄
saledjenic
approved these changes
Jan 13, 2025
| *params.NewProxyProvider(chainID, "proxy-grove", proxyUrl(stageName, "grove", chainName, networkName), false), | ||
| // Direct providers | ||
| *params.NewDirectProvider(chainID, "direct-infura", "https://mainnet.infura.io/v3/", true), | ||
| *params.NewDirectProvider(chainID, "direct-grove", "https://eth-archival.rpc.grove.city/v1/", false), |
There was a problem hiding this comment.
@dlipicar mentioned today that grove updated the format of their endpoints, maybe you can align with that?
| @@ -117,19 +118,25 @@ func OverrideEmbeddedProxyProviders(networks []params.Network, enabled bool, use | |||
| return updatedNetworks | |||
| } | |||
|
|
|||
| func deepCopyNetworks(networks []params.Network) []params.Network { | |||
| func DeepCopyNetwork(network params.Network) params.Network { | |||
There was a problem hiding this comment.
I agree with Igor's suggestion for this and the function below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up PR for the improved RPC configuration. See description: #6151