test_: status cli migration #6063
Conversation
Jenkins BuildsClick to see older builds (90)
|
fbarbu15
force-pushed
the
test-status-cli-migration
branch
3 times, most recently
from
70e6206 to
90b94a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6063 +/- ##
===========================================
- Coverage 60.92% 60.30% -0.63%
===========================================
Files 814 814
Lines 109253 109253
===========================================
- Hits 66564 65881 -683
- Misses 34885 35624 +739
+ Partials 7804 7748 -56
Flags with carried forward coverage won't be shown. Click here to find out more. |
fbarbu15
force-pushed
the
test-status-cli-migration
branch
2 times, most recently
from
cd3d55d to
0fa112a
Compare
fbarbu15
force-pushed
the
test-status-cli-migration
branch
from
b5284cb to
8a19451
Compare
tests-functional/config.json
Outdated
| "NativeCurrencyDecimals": 18, | ||
| "IsTest": false, | ||
| "Layer": 1, | ||
| "Enabled": true, |
There was a problem hiding this comment.
status-go fails to start with https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6063/13/artifact/tests-functional/statusd.log, due to comma in the end of the line, please remove and exclude from formatting
tests-functional/config.json
Outdated
| "Layer": 1, | ||
| "Enabled": true, | ||
| } | ||
| ], |
There was a problem hiding this comment.
status-go fails to start with https://ci.status.im/job/status-go/job/prs/job/tests-rpc/job/PR-6063/13/artifact/tests-functional/statusd.log, due to comma in the end of the line, please remove and exclude from formatting
There was a problem hiding this comment.
Hey @fbarbu15, great work, thank you ❤️
I didn't yet check the code, but do you think it's possible to split this into 2-3 PRs? E.g.:
- framework changes
- common functions
- test 1-1 chats
- test communities?
This would greatly simplify the burden of code review, and increase the speed of merging pieces. Otherwise the code review quality is very poor, it's very difficult to keep high concentration for so many changes.
I understand though that it's mostly just migration of existing tests. So even just a separate PR with framework adaptation (which is new code), and then tests on top will be super nice 🙌
Hi, thanks! |
Changes: