clean up ncli_testnet and reduce ValidIpAddress
usage
#5529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidIpAddress
isrequiresInit
and isn't compatible with the design of eithernim-serialization
ornim-confutils
:This addresses the non-
beacon_chain/
parts which don't have to be compatible withbeacon_chain/conf.nim
.It also does some other minor cleanup, e.g., some
proc
tofunc
inncli_testnet
.It bumps
nim-confutils
to pull in status-im/nim-confutils#94 (the only change).