Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up ncli_testnet and reduce ValidIpAddress usage #5529

Merged
merged 2 commits into from
Oct 26, 2023
Merged

clean up ncli_testnet and reduce ValidIpAddress usage #5529

merged 2 commits into from
Oct 26, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Oct 26, 2023

ValidIpAddress is requiresInit and isn't compatible with the design of either nim-serialization or nim-confutils:

type
  ValidIpAddress* {.requiresInit.} = object
    value: IpAddress

This addresses the non-beacon_chain/ parts which don't have to be compatible with beacon_chain/conf.nim.

It also does some other minor cleanup, e.g., some proc to func in ncli_testnet.

It bumps nim-confutils to pull in status-im/nim-confutils#94 (the only change).

@github-actions
Copy link

Unit Test Results

         9 files  ±0    1 092 suites  ±0   33m 43s ⏱️ + 2m 5s
  3 892 tests ±0    3 595 ✔️ ±0  297 💤 ±0  0 ±0 
15 973 runs  ±0  15 650 ✔️ ±0  323 💤 ±0  0 ±0 

Results for commit 0fa3829. ± Comparison against base commit 41dfc9e.

@tersec tersec merged commit 922283e into unstable Oct 26, 2023
11 checks passed
@tersec tersec deleted the 3ir branch October 26, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant