[WIP] High level api

[HugoGranstrom]

Hi, I found this project and it seemed like a good first project for interfacing with C (all the hard work has already been done by you 😉). Before I went any further with this I wanted to hear from you if my approach is reasonable or if it has any big flaws. This is my first time working with pointers so I may have gotten something wrong. I wrote a few tests that can be run with nimble test and they seem to work.

My thought is that we call the ptr mpd_t DecimalType instead for readablitity and we can initialize from ints and strings with newDecimal().

What do you think? 😄

[mratsim]

Nice start, here are a couple of pointers to improve the wrapping

[HugoGranstrom]

Now almost all functions from the "Arithmetic Functions" are wrapped (left out a few odd ones). I also tried to make it nimble installable by renaming and moving some things. On my machine, it works at least. Travis and Appveyor seem to disagree (are they on an older version perhaps?). I did also add templates for adding DecimalType with SomeNumber, I'm a bit split on that matter though as it kind of encourages not using arbitrary precision :/ Was thinking it would make statements like let a = x ^ 2 more intuitive by templating it to: let a = x ^ newDecimal($2). Any opinions on this?

This should definitely be ready for a test ride now. I have lots of more tests to write, and documenting all procs with a ## doc but I want an opinion before I procedes with that.

[mratsim]

Whoops, this passed under my radar, flooded with Github updates.

You shouldn't move to the src/ directory structure in the same PR as it makes review very hard. And while I prefer the src structure, it triggers several annoying issues with nim imports and nimble:

• Nimble package structure RFC nim-lang/Nim#6700
• [RFC] Nim package structure (library author point-of-view) nim-lang/RFCs#37
• Frictionless Nimble directory structures nim-lang/nimble#653

Don't hesitate to ping me on IRC/Gitter if I forget again.

[mratsim]

The last commit can be reverted. I can take care of the directory structure. The other commits are good.

[HugoGranstrom]

Hehe 😅 I got a bit too ambitious here. Should have realized it made a big mess of it all 🤣

Thank for handling it :-) Your feed must be bombarded with updates all the time, amazed that you can handle it 😄

I'll keep on working on this then 😉

[HugoGranstrom]

I think that's it 😅 Documentation comments are added to all non-obvious procs and next to everything should be covered in the tests.
If I have missed some very obvious procs: shout! 🤣🙏

[mratsim]

LGTM, it's just missing the auto deletion but I'll add it myself

[HugoGranstrom]

Awesome 😄

You know those stuff better than I do 👍😉