Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set limit of 1024KiB to boot nodes as well as for store nodes #31

Merged
merged 1 commit into from
May 30, 2024

Conversation

Ivansete-status
Copy link
Contributor

This PR is aiming to overcome an issue reported by @chaitanyaprem

I was testing lightpush and was facing this error randomly

ERROR[05-30|11:36:14.556|github.com/status-im/status-go/wakuv2/waku.go:971] could not send message envelopeHash=0x7f975bba4ce423ec16d9d08246b30ff6f215e0d0facb533f30d6aa68a4346222 pubsubTopic=/waku/2/rs/16/32 contentTopic=/waku/1/0x3bcb8b29/rfc26 timestamp=1,717,049,163,482,902,000 error="Message size exceeded maximum of 153600 bytes"

When i looked into it, i had noticed that some of the fleet nodes are returning this error. Had observed the same in shards.staging fleet node logs as well.
Taking a look at repo for vars in infra, i had noticed the following config only specified in store nodes and not in boot nodes.
Unless i am missing something, this doesn't seem right and needs to be fixed. For all shards.staging and shards.test nodes that run relay and lightpush we need to set maxMsgSize to 1MB.
Otherwise messages would not get propagated properly in the network and randomly things would get dropped.

nim_waku_max_msg_size: '1024KiB'

https://github.com/status-im/infra-shards/blob/9bbed44078d59537167495b21a018de191187395/ansible/group_vars/store.yml#L38

image

Copy link
Contributor

@apentori apentori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ivansete-status Ivansete-status merged commit 5f0928a into master May 30, 2024
2 checks passed
@Ivansete-status Ivansete-status deleted the add-limit-1024kib-all-pending-nodes branch May 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants