-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Going back to the latest stable VS Code version to perform e2e tests #1623
Conversation
250b2b6
to
17bedf2
Compare
Quality Gate passedIssues Measures |
e5bf028
to
8afc2b4
Compare
This reverts commit d2d4ce9.
This reverts commit 17bedf2.
Bumps the e2e-tests group with 1 update in the / directory: [chromedriver](https://github.com/giggio/node-chromedriver). Updates `chromedriver` from 128.0.3 to 129.0.0 - [Commits](giggio/node-chromedriver@128.0.3...129.0.0) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:development update-type: version-update:semver-major dependency-group: e2e-tests ... Signed-off-by: dependabot[bot] <[email protected]>
d1d5a5b
to
2c2d324
Compare
🤔, we want to make changes to the lifecycle ID stuff soon. So I'd say let's continue to run tests against the old version of vscode and consider disabling the relevant tests in favor of running against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
@sourishkrout Let's keep it open, I'll do a follow-up next week. For now, main is running using the v1.92.2, so no changes are necessary. I'll convert it to draft again. |
@pastuxso @sourishkrout , regarding this issue "It seems that the command > Developer: Reload Window is generating a disconnection between the test runner and the chromedriver. ", do you know if this will be fixed anytime soon? |
Hi @diyer! No, we don't. For now, We are using the 1.92.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
It seems that the command
> Developer: Reload Window
is generating a disconnection between the test runner and the chromedriver. This step is required to test Lifecycle Identity e2e Tests using different combinations of settings.This PR refactors the Lifecycle ID e2e tests to avoid the usage of Window Reloading and enabled the latest version again.
Reverts #1622
Related: webdriverio-community/wdio-vscode-service#136