Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going back to the latest stable VS Code version to perform e2e tests #1623

Merged
merged 12 commits into from
Sep 30, 2024

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Sep 6, 2024

It seems that the command > Developer: Reload Window is generating a disconnection between the test runner and the chromedriver. This step is required to test Lifecycle Identity e2e Tests using different combinations of settings.

This PR refactors the Lifecycle ID e2e tests to avoid the usage of Window Reloading and enabled the latest version again.

Reverts #1622

Related: webdriverio-community/wdio-vscode-service#136

@pastuxso pastuxso force-pushed the revert-1622-cris/tests-vscode-1.92.2 branch from 250b2b6 to 17bedf2 Compare September 18, 2024 15:52
Copy link

sonarcloud bot commented Sep 18, 2024

@pastuxso pastuxso changed the title Revert "Running e2e tests using VSCode v1.92.2" Going back to the latest stable VS Code version to perform e2e tests Sep 18, 2024
@pastuxso pastuxso marked this pull request as ready for review September 18, 2024 18:26
@pastuxso pastuxso force-pushed the revert-1622-cris/tests-vscode-1.92.2 branch from e5bf028 to 8afc2b4 Compare September 21, 2024 16:19
Bumps the e2e-tests group with 1 update in the / directory: [chromedriver](https://github.com/giggio/node-chromedriver).

Updates `chromedriver` from 128.0.3 to 129.0.0
- [Commits](giggio/node-chromedriver@128.0.3...129.0.0)

---
updated-dependencies:
- dependency-name: chromedriver
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: e2e-tests
...

Signed-off-by: dependabot[bot] <[email protected]>
@pastuxso pastuxso force-pushed the revert-1622-cris/tests-vscode-1.92.2 branch from d1d5a5b to 2c2d324 Compare September 23, 2024 14:40
@sourishkrout
Copy link
Member

🤔, we want to make changes to the lifecycle ID stuff soon. So I'd say let's continue to run tests against the old version of vscode and consider disabling the relevant tests in favor of running against stable later. That's a short-term trade-off that aligns better with our roadmap, @pastuxso.

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

@pastuxso
Copy link
Contributor Author

@sourishkrout Let's keep it open, I'll do a follow-up next week. For now, main is running using the v1.92.2, so no changes are necessary.

I'll convert it to draft again.

@pastuxso pastuxso marked this pull request as draft September 23, 2024 17:05
@diyer
Copy link

diyer commented Sep 24, 2024

@pastuxso @sourishkrout , regarding this issue "It seems that the command > Developer: Reload Window is generating a disconnection between the test runner and the chromedriver. ", do you know if this will be fixed anytime soon?

@pastuxso pastuxso marked this pull request as ready for review September 27, 2024 00:44
@pastuxso
Copy link
Contributor Author

@pastuxso @sourishkrout , regarding this issue "It seems that the command > Developer: Reload Window is generating a disconnection between the test runner and the chromedriver. ", do you know if this will be fixed anytime soon?

Hi @diyer! No, we don't. For now, We are using the 1.92.2.

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pastuxso pastuxso merged commit 4245a32 into main Sep 30, 2024
1 check passed
@pastuxso pastuxso deleted the revert-1622-cris/tests-vscode-1.92.2 branch September 30, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants