Refactor platform API message handling in kernel.ts #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pastuxso
commented
Feb 15, 2024
pastuxso
commented
- Remapped cloud API requests to platform API requests when platform authentication is enabled.
- Updated the response messages for saving cell executions to use platform API response messages.
- Added tests for platform API request handling and saving cell executions.
pastuxso
force-pushed
the
cpda/refactor-platform-kernel-events
branch
from
24fdf51
to
454b3e5
Compare
pastuxso
force-pushed
the
cpda/refactor-platform-kernel-events
branch
from
454b3e5
to
e992acd
Compare
sourishkrout
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
👍 LGTM - Using an TS interface ViewModel could also help an additional strategy to keep the "backend" interchangeable. However, if we are planning to decom the old backend it's probably not worth doing all the refactoring to implement said strategy.
Let's merge.
- Remapped cloud API requests to platform API requests when platform authentication is enabled. - Updated the response messages for saving cell executions to use platform API response messages. - Added tests for platform API request handling and saving cell executions.
pastuxso
force-pushed
the
cpda/refactor-platform-kernel-events
branch
from
e992acd
to
111ffef
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.