Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes support for new FQDNs to use Stateful IDP #1118

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Feb 13, 2024

When Stateful IDP is enabled, it doesn't require the same Fully Qualified Domain Names (FQDNs) as Runme through the setting runme.app.baseDomain. Therefore, this PR aims to streamline the configuration by removing the mapping for the app/platform subdomains specific to Stateful IDP.

@pastuxso pastuxso marked this pull request as ready for review February 13, 2024 17:50
Copy link

sonarcloud bot commented Feb 13, 2024

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pastuxso pastuxso merged commit 9db8c76 into main Feb 13, 2024
4 checks passed
@pastuxso pastuxso deleted the cpda/cold-fix-stateful-idp branch February 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants