Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell annotations dropdown component #1105

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Cell annotations dropdown component #1105

merged 2 commits into from
Feb 14, 2024

Conversation

degrammer
Copy link
Contributor

select-component

@pastuxso
Copy link
Contributor

Works fine on Linux:

image

image

@sourishkrout
Copy link
Member

Great. I'm going to push on top of this branch to make this mergable.

@sourishkrout sourishkrout force-pushed the 1104-cell-annotations-dropdown-component branch from 80069a5 to c9ed89c Compare February 14, 2024 14:01
sourishkrout
sourishkrout approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks for the cross-review @pastuxso.

@sourishkrout sourishkrout merged commit d56b53b into main Feb 14, 2024
2 checks passed
@sourishkrout sourishkrout deleted the 1104-cell-annotations-dropdown-component branch February 14, 2024 14:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@degrammer @pastuxso @sourishkrout