Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple args for interpreters #669

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Allow multiple args for interpreters #669

merged 1 commit into from
Sep 19, 2024

Conversation

sourishkrout
Copy link
Member

This is a bug where we only expect one argument. Downstream, the OS libraries expect arguments to be passed as an array.

This PR fixes this. Please see the test case.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

pastuxso
pastuxso approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sourishkrout sourishkrout merged commit 25d698b into main Sep 19, 2024
6 of 7 checks passed
@sourishkrout sourishkrout deleted the seb/multi-arg-interp branch September 19, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastuxso pastuxso pastuxso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourishkrout @pastuxso