Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitute category (deprecate) with tag #667

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Substitute category (deprecate) with tag #667

merged 4 commits into from
Sep 16, 2024

Conversation

sourishkrout
Copy link
Member

Users have reported that tags are self-explanatory, whereas categories are not.

  1. In the stable CLI interface, let's move off category without interrupting folks.
  2. In beta, there will only be a tag.

@sourishkrout
Copy link
Member Author

Another review, please, @pastuxso.

adambabik
adambabik reviewed Sep 14, 2024
View reviewed changes
internal/config/config_filter.go Show resolved Hide resolved
internal/config/autoconfig/autoconfig.go Show resolved Hide resolved
pkg/document/block.go Show resolved Hide resolved
pkg/document/frontmatter.go Show resolved Hide resolved
pkg/api/proto/runme/parser/v1/parser.proto Show resolved Hide resolved
pastuxso
pastuxso requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, I left you a minor comment.

internal/cmd/run.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sourishkrout sourishkrout merged commit 77ace52 into main Sep 16, 2024
7 checks passed
@sourishkrout sourishkrout deleted the seb/subst-category-with-tag branch September 16, 2024 17:04
@sourishkrout
Copy link
Member Author

Whoops, I somehow overlooked @adambabik's comments. I am addressing them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambabik adambabik adambabik left review comments

@pastuxso pastuxso pastuxso requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sourishkrout @pastuxso @adambabik