Temp provide autoconf defaults #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm now realizing I could have done this with dependency injection 🤔 |
sourishkrout
force-pushed
the
seb/autoconf-defaults
branch
from
452e0e5
to
804207f
Compare
adambabik
reviewed
Aug 14, 2024
adambabik
reviewed
Aug 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD if we automatically use defaults transparently or prompt the user to write a
runme.yamlto disk. However, for the time being this does not hard blockrunme betacommands without much explanation about the absence ofrunme.yaml.If we stick with transparent defaults we should probably rename
RootConfigtoRunmeConfigor some such.Changes to the config protos were necessary to distinguish between null bools versus false.