Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up s/errC/errc and rm expect pkg #644

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

adambabik
Copy link
Collaborator

@adambabik adambabik commented Aug 2, 2024

This change makes the naming of error channels consistent and removes the obsolete `expect' package.

@sourishkrout
Copy link
Member

This is just a capitalization change, right @adambabik?

@adambabik
Copy link
Collaborator Author

@sourishkrout and removal of the vendored expect package which is not used anymore.

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link

sonarcloud bot commented Aug 7, 2024

@sourishkrout sourishkrout merged commit ec4e6ef into main Aug 7, 2024
7 checks passed
@sourishkrout sourishkrout deleted the adamb/cleanup-errc-expect-pkg branch August 7, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants