-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIs to support Terminal integration #638
Conversation
da505d6
to
0646c78
Compare
Please review @adambabik. The |
Also, any idea why |
This reverts commit 7ff2855.
0b154af
to
3af6ad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments but no blockers.
It relies on the output of bash, but looking at the stack trace in the CI, it seems that On macOS it seems fine:
|
Yep, it runs pretty reliable on macOS but does the inverse on Linux/CI |
Quality Gate failedFailed conditions |
I tried to replicate it in a Docker container and it seems much more stable after this change. Usually it's a good indicator for running in the CI. Let's keep an eye on it. |
First stab at providing a session fork/rollup terminal. To make this work following provisional changes were necessary:
eval $(runme beta env source...)
- similar to howeval $(ssh-agent)
works.autoconf
errors since it currently relies on the presence ofrunme.yaml
- will walk this back as part of building outrunme beta
cmds & autoconf. However, don't want to hold up Runme Terminal progress.