We don't want two Project APIs #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourishkrout
force-pushed
the
seb/rm-legacy-prj-loader
branch
from
c6f01ef
to
adcc963
Compare
|
|
@adambabik, can you please take a look? We should have nuked the old Project API the first time around (irrespective that it lives under PS: I'm starting to wonder if we'd be better of moving things out under |
adambabik
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal tools (cross-repo) depend on this which why it was originally moved under
pkg.If anybody else depends on the old Project APIs, they can file a ticket since we don't make general stability guarantees (yet).