Add json to list cmd #379
Merged
Add json to list cmd #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourishkrout
requested changes
Sep 21, 2023
internal/cmd/list.go
Outdated
| } | ||
|
|
||
| return errors.Wrap(table.Render(), "failed to render") | ||
| if !isJSON { |
There was a problem hiding this comment.
We should probably break these out in functions (data passed to both is the same) for json and table respectively since the listCmd keeps growing.
internal/cmd/list.go
Outdated
| }, | ||
| } | ||
|
|
||
| cmd.PersistentFlags().BoolVar(&isJSON, "json", false, "This flag tells the list command to print the output in json") |
There was a problem hiding this comment.
Let's rename isJSON to formatJSON and move it into the function scope, just like here:
https://github.com/stateful/runme/blob/main/internal/cmd/fmt.go#L12-L13
Flags that are being used across commands can go into the module scope.
internal/cmd/list.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| err = jsonpretty.Format(io.Out, bytes.NewReader(by), " ", false) |
There was a problem hiding this comment.
I imagine jsonpretty has some benefits over just writing to output? Either way, the dependency to go-gh already exists so no harm done.
move row struct up a level
added test for json
|
Changes:
|
|
Tidied the modules and ran gofumpt ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #380