Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to go1.20 #322

Merged
merged 5 commits into from
Jul 10, 2023
Merged

bump to go1.20 #322

merged 5 commits into from
Jul 10, 2023

Conversation

mxsdev
Copy link
Contributor

@mxsdev mxsdev commented Jul 6, 2023 •
edited
Loading

Bumps required packages not currently supporting v1.20. Fixes lint issues related.

I added some lines to CONTRIBUTING.md to cover this case. Developers can run the following to get up-to-date:

runme run upgrade-go-120 --filename CONTRIBUTING.md

@sourishkrout sourishkrout self-requested a review July 10, 2023 21:01
sourishkrout
sourishkrout approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Worked like a charm.

@mxsdev mxsdev merged commit f300d3d into main Jul 10, 2023
@mxsdev mxsdev deleted the mxsdev/go120 branch July 10, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxsdev @sourishkrout