Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project mode is default unless chdir or filename flags are being used #318

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

sourishkrout
Copy link
Member

Question to consider: Will it be too confusing to turn on --allow-unnamed in file mode? It makes sense to me because when a file/dir is specified, the intention is to "consider all commands contained in one file". However, some folks might interpret it as an inconsistency. Wdyt @mxsdev?

@sourishkrout
Copy link
Member Author

sourishkrout commented Jun 30, 2023

Working on tests.

@mxsdev
Copy link
Contributor

mxsdev commented Jun 30, 2023

@sourishkrout

Will it be too confusing to turn on --allow-unnamed in file mode?

I think that's fine, consistency is valuable, but I think your initial expectation on the user's instincts is accurate. Two-way door anyhow 🚪

@sourishkrout
Copy link
Member Author

@sourishkrout

Will it be too confusing to turn on --allow-unnamed in file mode?

I think that's fine, consistency is valuable, but I think your initial expectation on the user's instincts is accurate. Two-way door anyhow 🚪

Agreed. Also, in the case where --index & --filename is being used it's actually important to consider all blocks vs just named ones.

@mxsdev
Copy link
Contributor

mxsdev commented Jun 30, 2023

Also, in the case where --index & --filename is being used it's actually important to consider all blocks vs just named ones.

Right, good catch!

@sourishkrout sourishkrout merged commit 168bd57 into main Jun 30, 2023
4 checks passed
@sourishkrout sourishkrout deleted the default-project-mode branch June 30, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants