Skip to content

Commit

Permalink
runner: rename runner.v2alpha1 to runner.v2 (#651)
Browse files Browse the repository at this point in the history
Simply rename `runner.v2alpha1` to `runner.v2`.

---------

Co-authored-by: Sebastian Tiedtke <[email protected]>
  • Loading branch information
adambabik and sourishkrout committed Aug 26, 2024
1 parent aa0c8fb commit db6699a
Show file tree
Hide file tree
Showing 36 changed files with 1,165 additions and 1,185 deletions.
1 change: 1 addition & 0 deletions buf.gen.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
version: v2
clean: true
plugins:
# Remote plugin. You can switch to a local one by using "go".
- remote: buf.build/protocolbuffers/go
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/beta/env_cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"google.golang.org/grpc/credentials"

runmetls "github.com/stateful/runme/v3/internal/tls"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
)

func envCmd(cflags *commonFlags) *cobra.Command {
Expand Down
4 changes: 2 additions & 2 deletions internal/cmd/beta/run_cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"github.com/stateful/runme/v3/internal/command"
"github.com/stateful/runme/v3/internal/config/autoconfig"
runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
"github.com/stateful/runme/v3/pkg/document"
"github.com/stateful/runme/v3/pkg/project"
)
Expand Down Expand Up @@ -117,7 +117,7 @@ func runCodeBlock(
return err
}

cfg.Mode = runnerv2alpha1.CommandMode_COMMAND_MODE_CLI
cfg.Mode = runnerv2.CommandMode_COMMAND_MODE_CLI

cmd, err := factory.Build(cfg, options)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions internal/cmd/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
parserv1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/parser/v1"
projectv1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/project/v1"
runnerv1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v1"
runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
"github.com/stateful/runme/v3/pkg/document/editor/editorservice"
)

Expand Down Expand Up @@ -119,7 +119,7 @@ The kernel is used to run long running processes like shells and interacting wit
if err != nil {
return err
}
runnerv2alpha1.RegisterRunnerServiceServer(server, runnerServicev2)
runnerv2.RegisterRunnerServiceServer(server, runnerServicev2)
}

healthcheck := health.NewServer()
Expand Down
10 changes: 5 additions & 5 deletions internal/command/command_docker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"go.uber.org/zap/zaptest"

"github.com/stateful/runme/v3/internal/dockerexec"
runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
)

func TestDockerCommand(t *testing.T) {
Expand All @@ -30,7 +30,7 @@ func TestDockerCommand(t *testing.T) {
ProgramName: "echo",
Arguments: []string{"-n", "test"},
Interactive: true,
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
},
CommandOptions{},
)
Expand All @@ -47,7 +47,7 @@ func TestDockerCommand(t *testing.T) {
ProgramName: "echo",
Arguments: []string{"-n", "test"},
Interactive: true,
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
},
CommandOptions{Stdout: stdout},
)
Expand All @@ -63,7 +63,7 @@ func TestDockerCommand(t *testing.T) {
&ProgramConfig{
ProgramName: "sleep",
Arguments: []string{"1"},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
},
CommandOptions{},
)
Expand All @@ -81,7 +81,7 @@ func TestDockerCommand(t *testing.T) {
&ProgramConfig{
ProgramName: "sh",
Arguments: []string{"-c", "exit 11"},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
},
CommandOptions{},
)
Expand Down
22 changes: 11 additions & 11 deletions internal/command/command_file_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package command
import (
"testing"

runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
)

func TestFileCommand(t *testing.T) {
Expand All @@ -16,12 +16,12 @@ func TestFileCommand(t *testing.T) {

cfg := &ProgramConfig{
ProgramName: "bash",
Source: &runnerv2alpha1.ProgramConfig_Commands{
Commands: &runnerv2alpha1.ProgramConfig_CommandList{
Source: &runnerv2.ProgramConfig_Commands{
Commands: &runnerv2.ProgramConfig_CommandList{
Items: []string{"echo -n test"},
},
},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_FILE,
Mode: runnerv2.CommandMode_COMMAND_MODE_FILE,
}

testExecuteCommand(t, cfg, nil, "test", "")
Expand All @@ -33,12 +33,12 @@ func TestFileCommand(t *testing.T) {
cfg := &ProgramConfig{
ProgramName: "",
LanguageId: "shellscript",
Source: &runnerv2alpha1.ProgramConfig_Commands{
Commands: &runnerv2alpha1.ProgramConfig_CommandList{
Source: &runnerv2.ProgramConfig_Commands{
Commands: &runnerv2.ProgramConfig_CommandList{
Items: []string{`echo -n "execute shellscript as shell script"`},
},
},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_FILE,
Mode: runnerv2.CommandMode_COMMAND_MODE_FILE,
}

testExecuteCommand(t, cfg, nil, "execute shellscript as shell script", "")
Expand All @@ -49,10 +49,10 @@ func TestFileCommand(t *testing.T) {

cfg := &ProgramConfig{
ProgramName: "python3",
Source: &runnerv2alpha1.ProgramConfig_Script{
Source: &runnerv2.ProgramConfig_Script{
Script: "print('test')",
},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_FILE,
Mode: runnerv2.CommandMode_COMMAND_MODE_FILE,
}

testExecuteCommand(t, cfg, nil, "test\n", "")
Expand All @@ -64,14 +64,14 @@ func TestFileCommand(t *testing.T) {

cfg := &ProgramConfig{
LanguageId: "ts",
Source: &runnerv2alpha1.ProgramConfig_Script{
Source: &runnerv2.ProgramConfig_Script{
Script: `function print(message: string): void {
console.log(message)
}
print("important message")
`,
},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_FILE,
Mode: runnerv2.CommandMode_COMMAND_MODE_FILE,
}

testExecuteCommand(t, cfg, nil, "important message\n", "")
Expand Down
12 changes: 6 additions & 6 deletions internal/command/command_inline_shell_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"

runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
)

func TestInlineShellCommand_CollectEnv(t *testing.T) {
Expand All @@ -29,15 +29,15 @@ func TestInlineShellCommand_CollectEnv(t *testing.T) {

cfg := &ProgramConfig{
ProgramName: "bash",
Source: &runnerv2alpha1.ProgramConfig_Commands{
Commands: &runnerv2alpha1.ProgramConfig_CommandList{
Source: &runnerv2.ProgramConfig_Commands{
Commands: &runnerv2.ProgramConfig_CommandList{
Items: []string{
"export TEST_ENV=1",
"sleep 5",
},
},
},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
}
sess := NewSession()
factory := NewFactory(WithLogger(zaptest.NewLogger(t)))
Expand Down Expand Up @@ -74,10 +74,10 @@ func testInlineShellCommandCollectEnv(t *testing.T) {

cfg := &ProgramConfig{
ProgramName: "bash",
Source: &runnerv2alpha1.ProgramConfig_Script{
Source: &runnerv2.ProgramConfig_Script{
Script: "export TEST_ENV=1",
},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
}
sess := NewSession()

Expand Down
4 changes: 2 additions & 2 deletions internal/command/command_inline_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ package command
import (
"testing"

runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
)

func TestInlineCommand_Noninteractive(t *testing.T) {
t.Parallel()
cfg := &ProgramConfig{
ProgramName: "echo",
Arguments: []string{"-n", "test"},
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
}
testExecuteCommand(t, cfg, nil, "test", "")
}
4 changes: 2 additions & 2 deletions internal/command/command_inline_unix_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package command
import (
"testing"

runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
)

func TestInlineCommand_Interactive(t *testing.T) {
Expand All @@ -14,7 +14,7 @@ func TestInlineCommand_Interactive(t *testing.T) {
ProgramName: "echo",
Arguments: []string{"-n", "test"},
Interactive: true,
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_INLINE,
Mode: runnerv2.CommandMode_COMMAND_MODE_INLINE,
}
testExecuteCommand(t, cfg, nil, "test", "")
}
8 changes: 4 additions & 4 deletions internal/command/command_terminal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"

runnerv2alpha1 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2alpha1"
runnerv2 "github.com/stateful/runme/v3/pkg/api/gen/proto/go/runme/runner/v2"
)

func TestTerminalCommand_EnvPropagation(t *testing.T) {
Expand All @@ -31,7 +31,7 @@ func TestTerminalCommand_EnvPropagation(t *testing.T) {
&ProgramConfig{
ProgramName: "bash",
Interactive: true,
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_TERMINAL,
Mode: runnerv2.CommandMode_COMMAND_MODE_TERMINAL,
},
CommandOptions{
Session: session,
Expand Down Expand Up @@ -90,7 +90,7 @@ func TestTerminalCommand_NonInteractive(t *testing.T) {
cmd, err := factory.Build(
&ProgramConfig{
ProgramName: "bash",
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_TERMINAL,
Mode: runnerv2.CommandMode_COMMAND_MODE_TERMINAL,
},
CommandOptions{
StdinWriter: stdinW,
Expand Down Expand Up @@ -125,7 +125,7 @@ func TestTerminalCommand_OptionsStdinWriterNil(t *testing.T) {
&ProgramConfig{
ProgramName: "bash",
Interactive: true,
Mode: runnerv2alpha1.CommandMode_COMMAND_MODE_TERMINAL,
Mode: runnerv2.CommandMode_COMMAND_MODE_TERMINAL,
},
CommandOptions{},
)
Expand Down
Loading

0 comments on commit db6699a

Please sign in to comment.