Experimental Command runme env store check (#537)

Adds an experimental command to check the smart store, it creates a new session, if the session creation fails, it prints the founded errors. Issue: #533 --------- Co-authored-by: Sebastian Tiedtke <[email protected]>
stateful · Mar 17, 2024 · 00b3953 · 00b3953
1 parent 7796d6a
commit 00b3953
Show file tree

Hide file tree

Showing 4 changed files with 80 additions and 5 deletions.
diff --git a/internal/cmd/common.go b/internal/cmd/common.go
@@ -314,6 +314,7 @@ func setRunnerFlags(cmd *cobra.Command, serverAddr *string) func() ([]client.Run
 			client.WithInsecure(fInsecure),
 			client.WithEnableBackgroundProcesses(EnableBackgroundProcesses),
 			client.WithEnvs([]string{fmt.Sprintf("%s=%d", envStackDepth, stackDepth)}),
+			client.WithEnvStoreType(runnerv1.SessionEnvStoreType_SESSION_ENV_STORE_TYPE_UNSPECIFIED),
 		}
 
 		switch strings.ToLower(SessionStrategy) {

diff --git a/internal/cmd/environment.go b/internal/cmd/environment.go
@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"strings"
 	"time"
@@ -15,6 +16,7 @@ import (
 	"google.golang.org/grpc/credentials"
 
 	runnerv1 "github.com/stateful/runme/v3/internal/gen/proto/go/runme/runner/v1"
+	"github.com/stateful/runme/v3/internal/runner/client"
 	runmetls "github.com/stateful/runme/v3/internal/tls"
 )
 
@@ -46,6 +48,7 @@ func storeCmd() *cobra.Command {
 	}
 
 	cmd.AddCommand(storeSnapshotCmd())
+	cmd.AddCommand(storeCheckCmd())
 
 	return &cmd
 }
@@ -71,7 +74,6 @@ func storeSnapshotCmd() *cobra.Command {
 			}
 
 			credentials := credentials.NewTLS(tlsConfig)
-
 			conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(credentials))
 			if err != nil {
 				return errors.Wrap(err, "failed to connect")
@@ -110,6 +112,63 @@ func storeSnapshotCmd() *cobra.Command {
 	return &cmd
 }
 
+func storeCheckCmd() *cobra.Command {
+	var (
+		serverAddr    string
+		getRunnerOpts func() ([]client.RunnerOption, error)
+	)
+
+	cmd := cobra.Command{
+		Hidden: true,
+		Use:    "check",
+		Short:  "Validates smart store",
+		Long:   "Connects with a running server to validates smart store, exiting with success or displaying API errors.",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			project, err := getProject()
+			if err != nil {
+				return err
+			}
+
+			runnerOpts, err := getRunnerOpts()
+			if err != nil {
+				return err
+			}
+
+			runnerOpts = append(
+				runnerOpts,
+				client.WithinShellMaybe(),
+				client.WithStdin(cmd.InOrStdin()),
+				client.WithCleanupSession(true),
+				client.WithStdout(cmd.OutOrStdout()),
+				client.WithStderr(cmd.ErrOrStderr()),
+				client.WithProject(project),
+				client.WithEnvStoreType(runnerv1.SessionEnvStoreType_SESSION_ENV_STORE_TYPE_OWL),
+			)
+
+			_, err = client.NewRemoteRunner(
+				cmd.Context(),
+				serverAddr,
+				runnerOpts...,
+			)
+			if err != nil {
+				// todo(sebastian): hack
+				errStr := err.Error()
+				parts := strings.Split(errStr, "Unknown desc = ")
+				_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Error: %s\n", parts[len(parts)-1])
+				return nil
+			}
+
+			// _, err = fmt.Printf("session created successfully in %s with id %s\n", project.Root(), runner.GetSessionID())
+			_, err = fmt.Println("Success")
+			return err
+		},
+	}
+
+	getRunnerOpts = setRunnerFlags(&cmd, &serverAddr)
+
+	return &cmd
+}
+
 func environmentDumpCmd() *cobra.Command {
 	cmd := cobra.Command{
 		Use:   "dump",

diff --git a/internal/runner/client/client.go b/internal/runner/client/client.go
@@ -43,6 +43,8 @@ type RunnerSettings struct {
 	tlsDir   string
 
 	envs []string
+
+	envStoreType runnerv1.SessionEnvStoreType
 }
 
 func (rs *RunnerSettings) Clone() *RunnerSettings {
@@ -218,6 +220,12 @@ func WithTempSettings(rc Runner, opts []RunnerOption, cb func() error) error {
 	return nil
 }
 
+func WithEnvStoreType(EnvStoreType runnerv1.SessionEnvStoreType) RunnerOption {
+	return withSettings(func(rs *RunnerSettings) {
+		rs.envStoreType = EnvStoreType
+	})
+}
+
 func ApplyOptions(rc Runner, opts ...RunnerOption) error {
 	for _, opt := range opts {
 		if err := opt(rc); err != nil {

diff --git a/internal/runner/client/client_remote.go b/internal/runner/client/client_remote.go
@@ -84,10 +84,13 @@ func (r *RemoteRunner) setupSession(ctx context.Context) error {
 		return nil
 	}
 
-	resp, err := r.client.CreateSession(ctx, &runnerv1.CreateSessionRequest{
-		Envs:    os.Environ(),
-		Project: ConvertToRunnerProject(r.project),
-	})
+	request := &runnerv1.CreateSessionRequest{
+		Envs:         os.Environ(),
+		Project:      ConvertToRunnerProject(r.project),
+		EnvStoreType: r.envStoreType,
+	}
+
+	resp, err := r.client.CreateSession(ctx, request)
 	if err != nil {
 		return errors.Wrap(err, "failed to create session")
 	}
@@ -297,3 +300,7 @@ func (r *RemoteRunner) GetEnvs(ctx context.Context) ([]string, error) {
 
 	return resp.Session.Envs, nil
 }
+
+func (r *RemoteRunner) GetSessionID() string {
+	return r.sessionID
+}