Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Upgrade @statechannels packages to @latest tag #31

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 9, 2021

This PR was created automatically by a github action.

@geoknee
Copy link
Contributor

geoknee commented Feb 9, 2021

The e2e-test job failed twice in a row, suggesting this is a genuine issue and not a flicker.

@geoknee
Copy link
Contributor

geoknee commented Feb 9, 2021

I'm not entirely sure what will happen when the next nightly build happens, because the GH action is going to try and reuse this branch. We might want to think about unique branch names for the GH action.

@andrewgordstewart
Copy link
Contributor

I'm not entirely sure what will happen when the next nightly build happens, because the GH action is going to try and reuse this branch. We might want to think about unique branch names for the GH action.

Screen Shot 2021-02-10 at 6 51 56 PM

It did just the right thing!

@andrewgordstewart
Copy link
Contributor

Screen Shot 2021-02-10 at 6 59 30 PM

VS

Screen Shot 2021-02-10 at 7 00 36 PM

This branch is not installing the next version.

@andrewgordstewart andrewgordstewart force-pushed the upgrade-statechannels-pkgs branch 2 times, most recently from bf26ac8 to 0e3a13e Compare February 11, 2021 05:24
@github-actions github-actions bot force-pushed the upgrade-statechannels-pkgs branch from 0e3a13e to af1d72d Compare February 11, 2021 08:16
@geoknee
Copy link
Contributor

geoknee commented Feb 11, 2021

It did just the right thing!

We can discuss that on this issue #36.

@geoknee
Copy link
Contributor

geoknee commented Feb 11, 2021

Screen Shot 2021-02-10 at 6 59 30 PM

VS

Screen Shot 2021-02-10 at 7 00 36 PM

This branch is not installing the next version.

Sorry, I'm not following you?

@andrewgordstewart
Copy link
Contributor

Screen Shot 2021-02-10 at 6 59 30 PM VS Screen Shot 2021-02-10 at 7 00 36 PM [This branch](https://github.com//pull/31/commits/c4c7ddfe1e80800e741022ec9af1c6cf9e4395f3#diff-7efec93aba423ea2d0a462279af9700dfe35b81bcb44cde3ec846a29c371632aR9) is not installing the [`next` version](https://www.npmjs.com/package/@statechannels/server-wallet/v/1.14.2-next.517ed467a.543).

Sorry, I'm not following you?

I think a force-push broke my links.

The photo was of the diff created by yesterday's action. I thought that it was not properly upgrading to the latest tag. But, according to the following, I think I was wrong?

Screen Shot 2021-02-11 at 4 22 43 PM

So, you can probably ignore that.

@github-actions github-actions bot force-pushed the upgrade-statechannels-pkgs branch from af1d72d to c240ae0 Compare February 12, 2021 08:16
@github-actions github-actions bot force-pushed the upgrade-statechannels-pkgs branch from c240ae0 to a7282a8 Compare February 12, 2021 20:00
@github-actions github-actions bot changed the title Upgrade @statechannels packages to @next tag Upgrade @statechannels packages to @latest tag Feb 12, 2021
@andrewgordstewart andrewgordstewart merged commit 06c31f0 into main Feb 12, 2021
@andrewgordstewart andrewgordstewart deleted the upgrade-statechannels-pkgs branch February 12, 2021 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants