Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, improve error messages in engine.constructObjectiveFromMessage() #938

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

NiloCK
Copy link
Contributor

@NiloCK NiloCK commented Oct 14, 2022

Related to statechannels/go-nitro-testground#134 (or, at least, to the debugging of this issue)

PR:

  • fixes an error message that declared a virtualfund had failed when in fact a virtualdefund had failed
  • augments the error messages to include the ID of the failed objectives
  • adds a small helper function to standardize these error messages

Code quality

  • I have written clear commit messages
  • I have performed a self-review of my own code
  • This change does not have an unduly wide scope
  • I have separated logic changes from refactor changes (formatting, renames, etc.)
  • I have commented my code wherever necessary (can be 0)
  • I have added tests that prove my fix is effective or that my feature works, if necessary
  • I have added comprehensive godoc comments

Project management

  • I have assigned myself to this PR
  • I have linked the appropriate github issue
  • I have assigned this PR to the appropriate GitHub project
  • I have assigned this PR to the appropriate GitHub Milestone

@NiloCK NiloCK self-assigned this Oct 14, 2022
@github-actions
Copy link

@NiloCK NiloCK merged commit 6538c9f into main Oct 14, 2022
@NiloCK NiloCK deleted the cmk.defund-error-msg branch October 14, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants