Merge pull request #49 from nebtrx/refactor-rescue-exception

Refactor `rescue Exception`
state-machines · Nov 14, 2016 · 616a607 · 616a607
2 parents 98d027c + 841620b
commit 616a607
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/state_machines/transition.rb b/lib/state_machines/transition.rb
@@ -290,7 +290,7 @@ def inspect
       def pausable
         begin
           halted = !catch(:halt) { yield; true }
-        rescue Exception => error
+        rescue => error
           raise unless @resume_block
         end
 

diff --git a/lib/state_machines/transition_collection.rb b/lib/state_machines/transition_collection.rb
@@ -168,7 +168,7 @@ def rollback
       def catch_exceptions
         begin
           yield
-        rescue Exception
+        rescue
           rollback
           raise
         end
@@ -210,7 +210,7 @@ def run_callbacks(index = 0)
           # Rollback only if exceptions occur during before callbacks
           begin
             super
-          rescue Exception
+          rescue
             rollback unless @before_run
             @success = nil  # mimics ActiveRecord.save behavior on rollback
             raise