account for aliased attributes when attribute methods are mixed in #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seuros here's the ActiveModel implementation |
|
@seuros tests pass locally - I can't see details of the build error. |
|
@seuros are you interested in merging this rather than state-machines/state_machines-activerecord#95? |
|
@seuros just checking to see if this is the route to go or the ActiveRecord PR. |
|
@seuros will this be merged? |
|
Yes, sorry. I'm back at OSSing. |
seuros
reviewed
Aug 2, 2022
| @@ -407,6 +407,10 @@ def around_validation(object) | |||
| def define_state_initializer | |||
| define_helper :instance, <<-end_eval, __FILE__, __LINE__ + 1 | |||
| def initialize(params = {}) | |||
| params.transform_keys! do |key| | |||
| self.class.attribute_aliases[key.to_s] || key.to_s | |||
| end if self.class.respond_to?(:attribute_aliases) | |||
There was a problem hiding this comment.
is the condition for old AM version ? We will support only 6.0+
seuros
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Moves
alias_attributefixes from state-machines/state_machines-activerecord#95