Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssg.running flag #151

Closed
wants to merge 5 commits into from

Conversation

simonhamp
Copy link
Contributor

Use-case

I have a site that uses the SSG but also runs fully dynamically elsewhere. Having this flag enables me to cut out/replace parts of templates that are 'too' dynamic with something more predictable for the SSG-generated version without having to completely remove chunks of template manually.

The case given in the readme is the most pressing example, but I'm sure there will be others.

Why a dynamic config key?

A static one will be present all of the time, so always true or always false. It could be added to the file, but that seems a bit redundant - no one should ever tamper with it.

Why not an env variable or some other variable?

Mainly down to antlers support - I wanted something I could access easily in my templates without much fuss and without polluting the global namespace with another variable.

The config array is readily accessible for this - and I checked: this still works even after running php artisan config:cache.

@simonhamp
Copy link
Contributor Author

Following some discussion on Discord, I'm closing this in favour of an alternative approach, that doesn't use a dynamic config key

@simonhamp simonhamp closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant