Test that directory is never cleared when passing url args.

statamic · Jul 13, 2023 · 6674ccb · 6674ccb
1 parent 9be567b
commit 6674ccb
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 8 deletions.
diff --git a/src/Generator.php b/src/Generator.php
@@ -91,8 +91,8 @@ public function generate($urls = '*')
 
         Site::setCurrent(Site::default()->handle());
 
-        if ($urls) {
-            $this->disableClear = true; // TODO: Needs PR #136
+        if (is_array($urls)) {
+            $this->disableClear = true;
         }
 
         $this

diff --git a/tests/GenerateTest.php b/tests/GenerateTest.php
@@ -62,6 +62,12 @@ public function it_generates_pages_for_site_fixture()
     /** @test */
     public function it_generates_specific_pages_when_passing_urls_as_args()
     {
+        $this
+            ->partialMock(Filesystem::class)
+            ->shouldReceive('deleteDirectory')
+            ->with(config('statamic.ssg.destination'), true)
+            ->never();
+
         $files = $this->generate(['urls' => ['/', 'topics', 'articles']]);
 
         $expectedFiles = [
@@ -93,9 +99,8 @@ public function it_generates_pages_to_custom_destination()
     /** @test */
     public function it_clears_destination_directory_when_generating_site()
     {
-        $files = $this->partialMock(Filesystem::class);
-
-        $files
+        $this
+            ->partialMock(Filesystem::class)
             ->shouldReceive('deleteDirectory')
             ->with(config('statamic.ssg.destination'), true)
             ->once();
@@ -106,9 +111,8 @@ public function it_clears_destination_directory_when_generating_site()
     /** @test */
     public function it_can_generate_site_without_clearing_destination_directory()
     {
-        $files = $this->partialMock(Filesystem::class);
-
-        $files
+        $this
+            ->partialMock(Filesystem::class)
             ->shouldReceive('deleteDirectory')
             ->with(config('statamic.ssg.destination'), true)
             ->never();
@@ -296,6 +300,12 @@ public function it_generates_associated_paginated_pages_when_generating_only_url
 EOT
         );
 
+        $this
+            ->partialMock(Filesystem::class)
+            ->shouldReceive('deleteDirectory')
+            ->with(config('statamic.ssg.destination'), true)
+            ->never();
+
         $files = $this->generate(['urls' => ['articles']]);
 
         $expectedArticlesFiles = [

diff --git a/tests/Localized/GenerateTest.php b/tests/Localized/GenerateTest.php
@@ -2,6 +2,7 @@
 
 namespace Tests\Localized;
 
+use Illuminate\Filesystem\Filesystem;
 use Statamic\Facades\Config;
 use Tests\Concerns\RunsGeneratorCommand;
 use Tests\TestCase;
@@ -258,6 +259,12 @@ public function it_generates_associated_paginated_pages_when_generating_only_loc
 EOT
         );
 
+        $this
+            ->partialMock(Filesystem::class)
+            ->shouldReceive('deleteDirectory')
+            ->with(config('statamic.ssg.destination'), true)
+            ->never();
+
         $files = $this->generate(['urls' => ['fr/le-articles']]);
 
         $expectedArticlesFiles = [