Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site defaults supporting multisite #352

Closed

Conversation

mwagena
Copy link

@mwagena mwagena commented Sep 19, 2024

With this PR support is being added for multisite.
Fallback is added when using a config file with path to the yaml file.

output paths will be ./content/seo/sitehandle/defaults.yaml

Closes #289.

@duncanmcclean
Copy link
Member

This PR still looks like it's a work-in-progress (lots of tests are failing & there's probably more to it than changing the file paths).

Going to mark this as a draft for now.

@duncanmcclean duncanmcclean marked this pull request as draft September 19, 2024 12:49
@mwagena
Copy link
Author

mwagena commented Sep 19, 2024

hi @duncanmcclean
I'll have to look into the tests then, the change is doing it's work when i tested it out while saving the 'site defaults' from within statamic cp. Also it returns the right data in the html pages in for example the <title> tag.

@mwagena
Copy link
Author

mwagena commented Sep 19, 2024

@duncanmcclean i have updated the code slightly to support older versions of Laravel, in my enthusiasm i forgot the config()->bool() and config()->string() methods were relatively new

@duncanmcclean
Copy link
Member

The tests still seem to be failing, I'm afraid.

When this is ready for us to look at, feel free to mark it as "Ready for review".

@mwagena mwagena marked this pull request as ready for review September 19, 2024 18:43
@mwagena
Copy link
Author

mwagena commented Sep 19, 2024

I have replaced the logic with regular php versions to support all Laravel versions, local tests ran OK.

@jesseleite
Copy link
Member

Thanks @mwagena for your work on this! I actually have some in-progress stuff on this front, which handles schema, but I'm also working out the UI in the CP for localizable site defaults as well. Going to close this for now so that we don't introduce two ways of doing the same thing, but I wanted to say I appreciate your PR ❤️

@jesseleite jesseleite closed this Sep 21, 2024
@mwagena
Copy link
Author

mwagena commented Sep 24, 2024

Thanks @mwagena for your work on this! I actually have some in-progress stuff on this front, which handles schema, but I'm also working out the UI in the CP for localizable site defaults as well. Going to close this for now so that we don't introduce two ways of doing the same thing, but I wanted to say I appreciate your PR ❤️

out of curiosity, what's the expectation on releasing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SiteDefaults are not localizable
3 participants