Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array_merge() error when parsing Antlers #253

Closed
wants to merge 1 commit into from

Conversation

o1y
Copy link
Contributor

@o1y o1y commented Jan 9, 2023

Fixes #252

@jesseleite
Copy link
Member

Hey thank you for the PR, but curious...

We're noticing that this suppresses the PHP error, but the generated SEO meta is still all borked. For example:

CleanShot 2023-01-09 at 17 07 56

The reason for this is because you don't have a home page at a url of /, so it can't find default values to fall back on. Does your site not have a / home page?

@o1y
Copy link
Contributor Author

o1y commented Jan 9, 2023

I see the problem. When using custom routes as described in the Ticket, there is no home site / anymore. Then my PR is not fixing the issue. Sorry 🙃

@o1y o1y closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when using Antlers
2 participants