-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Warm paginated pages with static:warm
command
#9493
Draft
duncanmcclean
wants to merge
25
commits into
5.x
Choose a base branch
from
warm-paginated-pages
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3c93cf3
When there's more pages, warm them
duncanmcclean 31a699a
Merge remote-tracking branch 'origin/4.x' into warm-paginated-pages
duncanmcclean 0bc87ea
wip
duncanmcclean d2fdfd7
make things work another way
duncanmcclean a697658
When `ignore_query_strings` is enabled, keep `page` parameter
duncanmcclean 98ceb6f
Make a "whitelisted query parameters" option
duncanmcclean 58d3d49
Add test
duncanmcclean 1231a6a
Fix `?` being appended without any whitelisted params present
duncanmcclean 4c7d410
Make pagination work with queued warming
duncanmcclean 4221c7c
Refactor
duncanmcclean e2373b8
Fix styling
duncanmcclean f369ea6
Merge branch '4.x' into warm-paginated-pages
jasonvarga 60ba73c
avoid controversial word
jasonvarga dfdb76e
Merge remote-tracking branch 'origin/5.x' into warm-paginated-pages
duncanmcclean 8aa2997
Merge branch '5.x' into warm-paginated-pages
duncanmcclean 3ee8e01
use `clientConfig()` method when new'ing up client
duncanmcclean 001d870
this should be allowed
duncanmcclean 529861f
Merge branch '5.x' into warm-paginated-pages
duncanmcclean bb344a5
Pass the Guzzle config through to the StaticWarmJob
duncanmcclean f59ed01
Merge remote-tracking branch 'origin/5.x' into warm-paginated-pages
duncanmcclean dc0a1fa
Merge remote-tracking branch 'origin/5.x' into warm-paginated-pages
duncanmcclean d3c23dd
Fix styling
duncanmcclean 9991ea4
no longer needed
duncanmcclean 83ee4da
Revert "no longer needed"
duncanmcclean 33ffe10
tidy up
duncanmcclean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we revisit this PR, we'll need to spend some time getting it working again when
ignore_query_strings
istrue
, as it looks like our changes in #10701 broke this. 😄Before #10701, this method ensured that only query parameters configured in the
allowed_query_strings
array (likepage
) were included in the filename.However, it now it seems like the
$url
being passed into this method already has the query parameters stripped off.